This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 04/13] constify maint.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 24 Jul 2014 02:47:14 +0100
- Subject: Re: [PATCH 04/13] constify maint.c
- Authentication-results: sourceware.org; auth=none
- References: <1406055319-26380-1-git-send-email-tromey at redhat dot com> <1406055319-26380-5-git-send-email-tromey at redhat dot com>
On 07/22/2014 07:55 PM, Tom Tromey wrote:
> {
> flagword flags = bfd_get_section_flags (abfd, asect);
> const char *name = bfd_section_name (abfd, asect);
> + const char *arg = datum;
>
> - if (arg == NULL || *((char *) arg) == '\0'
> - || match_substring ((char *) arg, name)
> - || match_bfd_flags ((char *) arg, flags))
> + if (arg == NULL || *(arg) == '\0'
I wouldn't mind removing the unnecessary parens
in '*(arg)' while we're touching this.
But, looks good.
Thanks,
Pedro Alves