This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3 v4] Introduce common/errors.h
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Thu, 24 Jul 2014 13:54:37 -0700
- Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h
- Authentication-results: sourceware.org; auth=none
- References: <1406206287-6817-1-git-send-email-gbenson at redhat dot com> <1406206287-6817-2-git-send-email-gbenson at redhat dot com> <21457 dot 17973 dot 551020 dot 113918 at ruffy dot mtv dot corp dot google dot com>
On Thu, Jul 24, 2014 at 10:45 AM, Doug Evans <dje@google.com> wrote:
> Gary Benson writes:
> > This introduces common/errors.h. This holds some error- and
> > warning-related declarations that can be used by the code in common.
> > Clients of the "common" code must provide definitions for these
> > functions.
> [...]
> > @@ -2144,6 +2144,10 @@ rsp-low.o: ${srcdir}/common/rsp-low.c
> > $(COMPILE) $(srcdir)/common/rsp-low.c
> > $(POSTCOMPILE)
> >
> > +errors.o: ${srcdir}/common/errors.c
>
> Nit: $(srcdir)
Holy cow, I see gdb/Makefile.in is rather inconsistent here.
Ok, no point in cleaning this up here.
One can even argue to leave it as ${srcdir}. Fine by me.