This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Always pass signals to the right thread.


Yao Qi writes:
 > >> > We want to know whether thread 1 is selected, so using "info threads 1"
 > >> > is simpler in the regexp pattern, like
 > >> > 
 > >> >  gdb_test "info threads 1" "\\\* 1${ws}Thread .*" "thread 1 selected"
 > > The reason I don't like "info threads 1" this is that if the test fails,
 > > when you go look at the logs, you don't see which thread was actually
 > > current, which tends to make debugging things a little easier.   But we
 > > can still simplify the patterns.  I was aiming at having no wildcards in
 > > the middle of the output, but that's really not necessary.
 > > I've simplified the patterns now.
 > 
 > OK.

A good thing to document in the test though, eh?
[i.e., *why* "info threads" is used instead of "info threads 1"]

[I realize the patch has been pushed, just a thought for future reference.]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]