This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] simplify target_is_pushed


> While working on target_is_pushed, I noticed that it is written in a
> strange way.  The code currently keeps an extra indirection, where a
> simple linked list traversal is all that is needed.  It seems likely
> this was done by copying and pasting other code.  However, there is no
> reason to do this and the more obvious code is simpler to reason
> about.  So, this patch change the implementation.
> 
> 2014-07-18  Tom Tromey  <tromey@redhat.com>
> 
> 	* target.c (target_is_pushed): Simplify.

Indeed. It looks like this one could go in on its own...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]