This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 13/13] Include string.h in common-defs.h
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 7 Aug 2014 09:13:06 +0100
- Subject: Re: [PATCH 13/13] Include string.h in common-defs.h
- Authentication-results: sourceware.org; auth=none
- References: <1406644635-1011-1-git-send-email-gbenson at redhat dot com> <1406644635-1011-14-git-send-email-gbenson at redhat dot com> <21474 dot 25859 dot 696381 dot 170030 at ruffy dot mtv dot corp dot google dot com>
Doug Evans wrote:
> Gary Benson writes:
> > This commit includes string.h in common-defs.h and removes all
> > other inclusions.
> >
> > gdb/
> > 2014-07-29 Gary Benson <gbenson@redhat.com>
> >
> > * common/common-defs.h: Include string.h.
> > * aarch64-tdep.c: Do not include string.h.
> > * ada-exp.y: Likewise.
[snip]
> > * xtensa-linux-nat.c: Likewise.
> > [... zoinks! :-) ...]
>
> Fwiw, I'd be happy with replacing all of this with:
>
> * common/common-defs.h: Include string.h.
> All other uses deleted.
>
> [and similarly elsewhere]
>
> No need to go back and change anything though.
> Just my $0.02.
> Some may have a rule to write this as you've done,
> but I think this is another case where we're bogging
> ourselves down in pedantic administrivia.
Ok, I'll do that next time.
Cheers,
Gary
--
http://gbenson.net/