This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
- From: Doug Evans <dje at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 14 Aug 2014 16:37:16 -0700
- Subject: Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
- Authentication-results: sourceware.org; auth=none
- References: <yjt2sil0atfw dot fsf at ruffy dot mtv dot corp dot google dot com> <20140814230502 dot GJ4881 at adacore dot com>
Joel Brobecker writes:
> > Should I apply this patch?
>
> Yeah, I would go ahead. It doesn't look like keeping it is going
> to make potential enhancement any easier...
>
> > 2014-08-13 Doug Evans <dje@google.com>
> >
> > * dwarf2read.c (dwarf_decode_lines_1): Delete local basic_block,
> > unused.
>
> --
> Joel
I'm guessing the same applies to local "column"?
2014-08-14 Doug Evans <dje@google.com>
* dwarf2read.c (dwarf_decode_lines_1): Delete local "column", unused.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index abe47d1..9240267 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17204,7 +17204,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
CORE_ADDR address = 0;
unsigned int file = 1;
unsigned int line = 1;
- unsigned int column = 0;
int is_stmt = lh->default_is_stmt;
int basic_block = 0;
int end_sequence = 0;
@@ -17412,7 +17411,7 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
}
break;
case DW_LNS_set_column:
- column = read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
+ (void) read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
line_ptr += bytes_read;
break;
case DW_LNS_negate_stmt: