This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Warnings in native MinGW32 build of GDB 7.8
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: yao at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Fri, 15 Aug 2014 05:33:00 -0700
- Subject: Re: Warnings in native MinGW32 build of GDB 7.8
- Authentication-results: sourceware.org; auth=none
- References: <83r40plpp3 dot fsf at gnu dot org> <53EAE47A dot 6030700 at codesourcery dot com> <83k36cifeq dot fsf at gnu dot org> <20140813174227 dot GF4881 at adacore dot com> <83d2c4i7y2 dot fsf at gnu dot org> <20140813181033 dot GG4881 at adacore dot com> <20140813182655 dot GH4881 at adacore dot com> <83bnroi5tc dot fsf at gnu dot org>
> > Attached is a patch that does that. Can you confirm it fixes your
> > warnings?
>
> Yes, it does. Thanks!
Thanks, Eli. I just pushed that patch.
And since I was missing one piece in the ChangeLog entry, I am
attaching the patch I ended up pushing. The diff itself is the same
though.
--
Joel
>From eb7a547ad40c97ca306e29c94678e4eab1822089 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 13 Aug 2014 11:15:00 -0700
Subject: [PATCH] Add "frame.h" #include in gdbarch.h.
This include is needed because gdbarch_dummy_id needs the full
definition of struct frame_id.
gdb/ChangeLog:
* gdbarch.sh: #include "frame.h" in gdbarch.h. Delete "struct
frame_info" partial declaration.
* gdbarch.h: Regenerate.
Tested on x86_64-linux by rebuilding GDB.
---
gdb/ChangeLog | 6 ++++++
gdb/gdbarch.h | 3 ++-
gdb/gdbarch.sh | 3 ++-
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 53cc615..6aa6592 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2014-08-15 Joel Brobecker <brobecker@adacore.com>
+
+ * gdbarch.sh: #include "frame.h" in gdbarch.h. Delete "struct
+ frame_info" partial declaration.
+ * gdbarch.h: Regenerate.
+
2014-08-15 Yao Qi <yao@codesourcery.com>
* dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'.
diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 5388e6e..0303b2e 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -35,9 +35,10 @@
#ifndef GDBARCH_H
#define GDBARCH_H
+#include "frame.h"
+
struct floatformat;
struct ui_file;
-struct frame_info;
struct value;
struct objfile;
struct obj_section;
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 61d0781..2a8bca8 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1124,9 +1124,10 @@ cat <<EOF
#ifndef GDBARCH_H
#define GDBARCH_H
+#include "frame.h"
+
struct floatformat;
struct ui_file;
-struct frame_info;
struct value;
struct objfile;
struct obj_section;
--
1.9.1