This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Typos in gdb/mi

From: Vladimir Prus <ghost at cs dot msu dot su>
To: gdb-patches at sourceware dot org
Date: Mon, 18 Aug 2014 18:03:24 +0400
Subject: Re: [PATCH] Typos in gdb/mi
Authentication-results: sourceware.org; auth=none
References: <53F1BDFA dot 1090101 at ericsson dot com>

On 08/18/2014 12:48 PM, Andreas From wrote:

Hi,

This is a first patch for setting up the account.

I fixed miscellaneous typos and capitalization for "gdb", "gcc", "mi" and "cli" and replaced "var obj" -> "varobj" in code comments in MI
parts.

I de-capitalized VAROBJ in one comment since it is not a variable but the type referred to.

Would this be OK to commit? And, if so, can someone help me further with access for pushing?


Hi Andreas,

I understand the motivation for making the change, and it does make the code better; thanks for taking the time!

However, I was burned in past, when such cleanup patches caused merge problems for any local patches
anybody might have. I wonder what others think?

- Volodya

Follow-Ups:
- Re: [PATCH] Typos in gdb/mi
  - From: Joel Brobecker

References:
- [PATCH] Typos in gdb/mi
  - From: Andreas From

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]