This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5 v7] Introduce common-debug.h
- From: Gary Benson <gbenson at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Steve Ellcey <sellcey at mips dot com>, Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
- Date: Wed, 20 Aug 2014 13:09:34 +0100
- Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
- Authentication-results: sourceware.org; auth=none
- References: <20140819091220 dot GB6493 at blade dot nx> <1408490530 dot 31355 dot 15 dot camel at ubuntu-sellcey> <20140820085243 dot GA2694 at blade dot nx> <15329331 dot NicJ8HFAzI at vapier>
Mike Frysinger wrote:
> On Wed 20 Aug 2014 09:52:43 Gary Benson wrote:
> > I don't see any callers for SIM's debug_printf. Is this dead code
> > that can be removed, or is it provided as a convenience/library
> > function?
>
> it is not currently being used, but it really really should be in
> some targets
Ok.
> > Steve, you can probably work around this for now by adding:
> >
> > #define debug_printf gdb_debug_printf
> >
> > at the top of GDB's common/common-debug.h. If SIM's debug_printf
> > cannot be removed then maybe we will have to add some hack like
> > this to GDB permanently.
>
> i'm fine with updating sim/common/sim-trace.h with that idea:
> #define debug_printf sim_debug_printf
>
> all the symbols coming out of the sim really should be namespaced
Great. I can put together a patch if you like (or I can make the
change, or you can... whatever's easiest!) I don't know much about
SIM... is there a list to mail patches to? And, is its upstream
repo the same as binutils+GDB or is it imported from somewhere else
like libiberty?
Cheers,
Gary
--
http://gbenson.net/