This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] Introduce common/gdb_setjmp.h
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Aug 2014 17:54:03 +0100
- Subject: Re: [PATCH 3/5] Introduce common/gdb_setjmp.h
- Authentication-results: sourceware.org; auth=none
- References: <1408351618-21013-1-git-send-email-gbenson at redhat dot com> <1408351618-21013-4-git-send-email-gbenson at redhat dot com>
On 08/18/2014 09:46 AM, Gary Benson wrote:
> This commit creates a new file, common/gdb_setjmp.h, to hold some
> portability macros for setjmp/longjmp et al. that are used by the
> exceptions subsystem and by the demangler crash catcher.
Looks like this one stands on its own.
OK, with ...
>
> gdb/
> 2014-08-18 Gary Benson <gbenson@redhat.com>
>
> * common/gdb_setjmp.h: New file.
> * Makefile.in (HFILES_NO_SRCDIR): Add common/gdb_setjmp.h.
> * configure.ac: Move sigsetjmp check...
> * common/common.m4: ...here.
> * configure: Regenerate.
> * cp-support.c (SIGJMP_BUF): Undefine.
... please say "Delete.". "Undefine" makes the reader expect
an #undef.
> (SIGSETJMP): Likewise.
> (SIGLONGJMP): Likewise.
> * exceptions.h (gdb_setjmp.h): Include.
> (setjmp.h): Do not include.
> (EXCEPTIONS_SIGJMP_BUF): Undefine.
Likewise.
> (EXCEPTIONS_SIGSETJMP): Likewise.
> (EXCEPTIONS_SIGLONGJMP): Likewise.
> Replace all uses of EXCEPTIONS_SIG* macros with SIG* macros
> from gdb_setjmp.h.
> * exceptions.c: Likewise.
>
> gdb/gdbserver/
> 2014-08-18 Gary Benson <gbenson@redhat.com>
>
> * config.in: Regenerate.
> * configure: Likewise.
Thanks,
Pedro Alves