Re: [PATCH 0/3] Keep track of files copied to host and target

[Doug Evans <dje at google dot com>]

Yao Qi writes:
 > On 08/20/2014 11:48 PM, Doug Evans wrote:
 > > How about separating out 3/3 from the rest of the patch set.
 > > We can fix this part now, and unblock that from the discussion of
 > > the rest of the patch set.
 > 
 > That sounds good to me.  In fact patch 3/3 is independent and can be
 > used as-is.  I update commit log a little bit to explain why *.py files
 > are not removed on host.  Is it OK?
 > 
 > -- 
 > Yao (  )
 > 
 > Subject: [PATCH] Copy .py files to remote host
 > 
 > Some gdb.python/*.exp tests fail because the .py files aren't copied
 > to the (remote) host.  This patch is to copy needed .py files to host.
 > Most of gdb.python/*.exp tests do this.
 > 
 > As it is still controversial to delete *.py files on host, we don't do
 > that in this patch.
 > 
 > gdb/testsuite:
 > 
 > 2014-08-21  Yao Qi  <yao@codesourcery.com>
 > 
 > 	* gdb.python/py-finish-breakpoint.exp: Copy .py file to host.
 > 	* gdb.python/py-finish-breakpoint2.exp: Likewise.
 > 	* gdb.python/python.exp: Likewise.  Use .py file on the host
 > 	instead of the build.

LGTM

For reference sake,

It seems there's a roughly equal measure of usage of
remote_download versus gdb_remote_download in the testsuite
for downloading to the host
(though I didn't count which usages of gdb_remote_download
actually need its extra functionality).
Long term, if you wanted to migrate other uses of remote_download
to gdb_remote_download for nothing other than consistency's sake
that would be fine with me.