This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Fri, 22 Aug 2014 17:40:55 +0100
- Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
- Authentication-results: sourceware.org; auth=none
- References: <1408708971-15299-1-git-send-email-yao at codesourcery dot com>
Hi Yao,
On 08/22/2014 01:02 PM, Yao Qi wrote:
> /* Read a partial die corresponding to a subprogram and create a partial
> symbol for that subprogram. When the CU language allows it, this
> routine also defines a partial symbol for each nested subprogram
> - that this subprogram contains.
> + that this subprogram contains. If SET_ADDRMAP is true, record the
> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
> + highest PC values found in PDI.
The last sentence is missing the verb?
> - DIE my also be a lexical block, in which case we simply search
> + PDI may also be a lexical block, in which case we simply search
> recursively for suprograms defined inside that lexical block.
As long as we're fixing typos, there's another here "suprograms".
Otherwise looks fine to me.
Thanks,
Pedro Alves