This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 0/4] Fix recent sim/*/config.in fallout: frv, m32r, sh64, iq2000
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 23 Aug 2014 05:13:15 +0200
- Subject: Re: [RFC 0/4] Fix recent sim/*/config.in fallout: frv, m32r, sh64, iq2000
- Authentication-results: sourceware.org; auth=none
> From: Hans-Peter Nilsson <hp@axis.com>
> Date: Wed, 20 Aug 2014 06:28:23 +0200
> Recently, a change requiring -ldl due to bfd plugin default changing
> from off to on, spread throughout the generated configury files, for
> simulators as well as gdb. In that process, sim/*/config.in for the
> sims below was regenerated for the first time since 2012. This had
> build-breaking fallouts for some simulator showing bloopers in changes
> from around 2013-03-23, attempts enabling sim-hardware and
> dv-sockser.o. Here's my take on fixing that: let's return to the
> state before those attempts. This is a request-for-comments, I'll
> commit this in a few days unless someone has a better idea, one that
> lets these simulators build *without* --{enable,disable} options and
> where committing this would still not be an incremental improvement.
Now committed. I'll stop here, noting that possible further cleanups
would be to fix the buggy SIM_AC_OPTION_HARDWARE and decouple the
prerequisites for dv-sockser.o from the act of actually enabling it
(e.g. the now combined effect of HAVE_DV_SOCKSER). Please also, if
you consider "re-enabling" simulated hardware for these sims, first
investigate whether all the wires and plumbing is in place for it to
actually make a difference in function for the particular sim. Also,
test-cases for the enabled simulated hardware would be helpful, even a
simple "hello, world" to a simulated serial port.
brgds, H-P