This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 25 Aug 2014 10:57:56 +0100
- Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
- Authentication-results: sourceware.org; auth=none
- References: <1408708971-15299-1-git-send-email-yao at codesourcery dot com> <53F77297 dot 80704 at redhat dot com> <87lhqegfrt dot fsf at codesourcery dot com>
On 08/24/2014 02:48 PM, Yao Qi wrote:
>>> >> - that this subprogram contains.
>>> >> + that this subprogram contains. If SET_ADDRMAP is true, record the
>>> >> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
>>> >> + highest PC values found in PDI.
>> >
>> > The last sentence is missing the verb?
> Ur, "are" is missing, I think. It should be "... are found in PDI.".
> Fixed in the updated patch.
...
> + that this subprogram contains. If SET_ADDRMAP is true, record the
> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
> + highest PC values are found in PDI.
Hmm. I still can't parse this though. It's actually the "to the" part
that seems to miss a verb to me. Isn't a "Set" missing instead of
"are"? Like:
that this subprogram contains. If SET_ADDRMAP is true, record the
covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest and
highest PC values found in PDI.
Thanks,
Pedro Alves