This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix xmethod Python so that it works with Python 3
- From: Siva Chandra <sivachandra at google dot com>
- To: Doug Evans <dje at google dot com>, Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Sat, 30 Aug 2014 06:48:07 -0700
- Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gwQF17FXajAbgyQFhWSS2ymwRxMdPNY3y-AJZmfcwc4qg at mail dot gmail dot com> <21485 dot 14738 dot 947462 dot 758709 at ruffy dot mtv dot corp dot google dot com> <CAGyQ6gwhHznkNj33gxk-du+VL=wRp1KUP-k1xZPTkndbnQAbjg at mail dot gmail dot com>
On Fri, Aug 15, 2014 at 6:16 PM, Siva Chandra <sivachandra@google.com> wrote:
> On Thu, Aug 14, 2014 at 3:34 PM, Doug Evans <dje@google.com> wrote:
>> Siva Chandra writes:
>> > The attached patch fixes the "no space before parenthesis in Python"
>> > comment by Joel. The comment was for the changes in the test suite.
>> > Going by examples, I thought the test case code (but not the .exp
>> > files) did not require adherence to coding style.
>> >
>> > I also agree with Joel that this patch should also pushed to the 7.8 branch.
>> >
>> > ChangeLog:
>> > 2014-08-14 Siva Chandra Reddy <sivachandra@gmail.com>
>> >
>> > gdb/
>> >
>> > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the
>> > 'items' methods instead of 'iteritems' method on dictionaries.
>> >
>> > gdb/testsuite/
>> >
>> > * gdb.python/py-xmethods.py (A_getarrayind)
>> > (E_method_char_worker.__call__, E_method_int_worker.__call__):
>> > Use 'print' with function call syntax.
>> > (E_method_matcher.match): Fix tab vs space indentation mixup.
>>
>> LGTM
>
> Pushed 940df408121be31beed22ef7a5ad133cb1592726.
Missed asking: OK for 7.8 branch?