This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>, Yao Qi <yao at codesourcery dot com>
- Date: Tue, 9 Sep 2014 17:32:28 +0100
- Subject: Re: [PATCH 2/2] GDB/testsuite: Add/correct gdb.reverse timeout tweaks
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1407231515400 dot 16254 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1407231529220 dot 16254 at tp dot orcam dot me dot uk> <53D79621 dot 8050805 at redhat dot com>
On Tue, 29 Jul 2014, Pedro Alves wrote:
> Looks good to me.
Thanks, I have applied this change now.
> I wonder though, whether:
>
> On 07/24/2014 11:39 PM, Maciej W. Rozycki wrote:
> > +set savedtimeout $timeout
> > +if { [target_info exists gdb,timeout]
> > + && $timeout < [target_info gdb,timeout] } {
> > + set oldtimeout [target_info gdb,timeout]
> > +} else {
> > + set oldtimeout $timeout
> > +}
> > +set timeout [expr $oldtimeout * 2]
>
> ... this pattern can be somewhat factored into a
> procedure? That'd also serve the duty of being the
> simple place we document it.
Good point, that would be a nice improvement indeed.
I have been continuously being dragged off to various other stuff
recently though so if I were to consider this improvement a prerequisite
to pushing the timeout tweaks I have made here, they may well have not
ended up integrated within a reasonable time frame. I have therefore
committed them as they are, as noted above, so as not to let perfect be
the enemy of good. I'll keep in mind that our timeouts would benefit from
some polishing yet and hopefully get back to it sometime sooner rather
than later. Unless someone beats me to it, that is -- I won't mind that,
not a little bit.
The stuff is easy to grep for, so the pieces to improve should be easy to
identify.
Maciej