This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, microblaze]: Port of Linux gdbserver


On 09/10/14 07:22, Ajit Kumar Agarwal wrote:
Please find the updated patch with review feedbacks are incorporated.

    [Patch, microblaze]: Port of Linux gdbserver

     This patch is the port of Linux gdbserver.

     ChangeLog:
     2014-10-09  Ajit Agarwal  <ajitkum@xilinx.com>

         * configure.host (microblaze): New.
         (microblaze*-*-linux*): New.
         * configure.tgt (build_gdbserver): New Definition.
         * gdbserver/Makefile.in (microblaze-linux.c): New target.
         * gdbserver/configure.srv (microblaze*-*-linux*): New target.
         * gdbserver/linux-microblaze-low.c: New file.

     Signed-off-by:Ajit Agarwal ajitkum@xilinx.com

Please review your patches before you (re)submit them.

+  /* If necessary, recognize more trap instructions here.  GDB only uses the
+      one.  */

One line.

+  else
+    {
+        if (size < sizeof (long))
+          supply_register (regcache, regno, buf + sizeof (long) - size);
+        else
+          supply_register (regcache, regno, buf);
+    }
+}

Fix indent.

+static struct usrregs_info microblaze_usrregs_info =
+{
+   microblaze_num_regs,
+   microblaze_regmap,
+};

Fix indent.

How has this been tested?   Please be specific.

Did you rebuild and test after making changes to the patch?


--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]