This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch, microblaze]: Port of Linux gdbserver


>> How has this been tested?   Please be specific.

The changes are tested with the Xilinx PetaLinux. The Petalinux is booted up with QEMU and the gdbserver is run as follows.

/bin/gdbserver HOST:1234 application.elf.

From another terminal mb-gdb is run and attached to gdbserver process run before using tar remote command and 
Break point is set and continue.

All the testing has been done with little-endian binaries. Even the Linux kernel that got booted up are little endian. 

Rest my answers are inlined below.

Thanks & Regards
Ajit

-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com] 
Sent: Wednesday, September 10, 2014 8:09 PM
To: Ajit Kumar Agarwal; Joel Brobecker
Cc: gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Port of Linux gdbserver

On 09/10/14 07:22, Ajit Kumar Agarwal wrote:
> Please find the updated patch with review feedbacks are incorporated.
>
>     [Patch, microblaze]: Port of Linux gdbserver
>
>      This patch is the port of Linux gdbserver.
>
>      ChangeLog:
>      2014-10-09  Ajit Agarwal  <ajitkum@xilinx.com>
>
>          * configure.host (microblaze): New.
>          (microblaze*-*-linux*): New.
>          * configure.tgt (build_gdbserver): New Definition.
>          * gdbserver/Makefile.in (microblaze-linux.c): New target.
>          * gdbserver/configure.srv (microblaze*-*-linux*): New target.
>          * gdbserver/linux-microblaze-low.c: New file.
>
>      Signed-off-by:Ajit Agarwal ajitkum@xilinx.com

Please review your patches before you (re)submit them.

+  /* If necessary, recognize more trap instructions here.  GDB only uses the
+      one.  */

>>One line.

 If this exceeds the 80 Cols then also it should be in one Line.
+  else
+    {
+        if (size < sizeof (long))
+          supply_register (regcache, regno, buf + sizeof (long) - size);
+        else
+          supply_register (regcache, regno, buf);
+    }
+}

>>Fix indent.

Could you please explain what indentation is required in the above case.

+static struct usrregs_info microblaze_usrregs_info = {
+   microblaze_num_regs,
+   microblaze_regmap,
+};

>>Fix indent.

I will fix this.

>>How has this been tested?   Please be specific.

Answered above.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]