This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 02/13] regcache: Add functions suitable for regset_supply/collect.
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 12 Sep 2014 14:10:44 +0200
- Subject: Re: [PATCH v3 02/13] regcache: Add functions suitable for regset_supply/collect.
- Authentication-results: sourceware.org; auth=none
- References: <1406804686-9437-1-git-send-email-arnez at linux dot vnet dot ibm dot com> <1406804686-9437-3-git-send-email-arnez at linux dot vnet dot ibm dot com> <87lhppnb33 dot fsf at kepler dot schwinge dot homeip dot net>
On Thu, Sep 11 2014, Thomas Schwinge wrote:
> commit a01cbb490b34eda832c0215b8447e6aef68b0278
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date: Thu Sep 11 22:30:23 2014 +0200
>
> Make gdb/regcache.h self-contained.
>
> gdb/
> * regcache.h (struct regset): Declare.
>
> Commit 0b3092721e5cfa1697f1dafe81efefdbb0236f21 added uses of struct regset to
> gdb/regcache.h, but that struct is not declared in this file, and, as it
> happens, also nowhere else in the #include chain on x86 GNU/Hurd. This results
> in warnings/errors such as:
>
> gcc-4.8 [...] ../../W._C._Handy/gdb/gdb.c
> In file included from ./nm.h:25:0,
> from ../../W._C._Handy/gdb/defs.h:454,
> from ../../W._C._Handy/gdb/gdb.c:19:
> ../../W._C._Handy/gdb/regcache.h:190:9: warning: 'struct regset' declared inside parameter list [enabled by default]
> size_t size);
> ^
> ../../W._C._Handy/gdb/regcache.h:190:9: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> ../../W._C._Handy/gdb/regcache.h:193:10: warning: 'struct regset' declared inside parameter list [enabled by default]
> int regnum, void *buf, size_t size);
> ^
Right. Sorry for the breakage.