This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Gary Benson <gbenson at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 12 Sep 2014 11:29:51 -0700
- Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
- Authentication-results: sourceware.org; auth=none
- References: <1409320299-6812-1-git-send-email-gbenson at redhat dot com> <1409320299-6812-4-git-send-email-gbenson at redhat dot com> <21520 dot 36381 dot 756875 dot 963606 at ruffy2 dot mtv dot corp dot google dot com> <20140911102659 dot GA17472 at blade dot nx> <5412DEB5 dot 6020706 at redhat dot com> <21523 dot 9502 dot 168492 dot 803068 at ruffy2 dot mtv dot corp dot google dot com> <54132B55 dot 9000108 at redhat dot com> <21523 dot 12189 dot 134570 dot 770432 at ruffy2 dot mtv dot corp dot google dot com> <5413305B dot 6020402 at redhat dot com> <21523 dot 13993 dot 986533 dot 615240 at ruffy2 dot mtv dot corp dot google dot com> <54133939 dot 70801 at redhat dot com>
On Fri, Sep 12, 2014 at 11:19 AM, Pedro Alves <palves@redhat.com> wrote:
> On 09/12/2014 07:08 PM, Doug Evans wrote:
>
>> And I remembered you saying:
>>
>> > I just now noticed the elephant in the room -- target_stop is
>> > asynchronous, doesn't wait for a stop, while and target_stop_ptid
>> > is synchronous. [...]
>>
>> If the above code is right, I think a clarifying comment
>> is required somewhere. It's odd that one can call agent_run_command
>> when the inferior may or may not be stopped yet.
>> [Or is there a bug here? - if I'm reading the gdbserver version
>> correctly it first waits for the inferior to stop]
>
> It's a bug.
>
> (Note that the GDB side interfaces with an out-of-tree
> agent, not GDBserver's agent. I don't know the status of
> that agent.)
Heh.
Data point that target_stop should be named target_stop_async?
1/2 :-)
[I'd like to point out that all I had to do was read the code (glance
is more apt) to see the bug (given that your comment about target_stop
was still fresh in my mind). Unambiguous/clear function names are
worth at least some effort.]
btw, out-of-tree agent, and not gdbserver's agent?
That's odd. Where would I find this agent?