This is the mail archive of the
mailing list for the GDB project.
Re: [PATCHv3,Hurd] Add hardware watch support
- From: Samuel Thibault <samuel dot thibault at gnu dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, Gary Benson <gbenson at redhat dot com>, bug-hurd at gnu dot org, gdb-patches at sourceware dot org
- Date: Fri, 12 Sep 2014 23:13:54 +0200
- Subject: Re: [PATCHv3,Hurd] Add hardware watch support
- Authentication-results: sourceware.org; auth=none
- References: <20140910224919 dot GP3244 at type dot youpi dot perso dot aquilenet dot fr> <874mwcpvsy dot fsf at schwinge dot name> <20140912180054 dot GB4448 at type dot youpi dot perso dot aquilenet dot fr> <20140912200141 dot GH4871 at adacore dot com>
Joel Brobecker, le Fri 12 Sep 2014 13:01:41 -0700, a écrit :
> > > Many thanks for persisting with this patch.
> > I have to say I'm almost about to give up with submitting it.
> I would be very interested in hearing your honest feedback on this.
> I know it took a long time, and we're not always very responsive,
> but we try our best. If we could hear what made you feel this way,
> I would like to try to see if there are any ways we can improve
> the situation for you.
I'm sorry I wrote it in such a harsh way while you were all polite in
your requests. Actually it's an unfortunate combination of me also
having a pending patch to the Linux kernel which has been waiting for
several years, with only sporadic reviews, then a request for reshaping,
and ended up with a "well, the way it is done will not fly" without
very much details or discussion, and another pending patch to qemu,
which apparently nobody has the time to review, while they are really
interested in it. Seeing a submission to gdb getting stuck on missing
line breaks got me a bit on my nerves. Fortunately it wasn't only
about that, but also important changes, so I carried on, but having to
resubmit only for missing spaces or new lines would have been really
hard to me, since I don't really plan to submit many patches to gdb,
and I know I'll always make this kind of mistakes since I'm submitting
patches to a lot of various projects with very differing coding styles.
What may help in the process would be to have a script which checks for
style. The Linux kernel's checkpatch.pl is a very good approach, since
one can get to check one's own style quite thoroughly before submitting.