This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] after gdb_run_cmd, gdb_expect -> gdb_test_multiple/gdb_test
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org, Ulrich Weigand <uweigand at de dot ibm dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Fri, 12 Sep 2014 22:44:39 +0100
- Subject: Re: [PATCH] after gdb_run_cmd, gdb_expect -> gdb_test_multiple/gdb_test
- Authentication-results: sourceware.org; auth=none
- References: <1410490007-19756-1-git-send-email-emachado at linux dot vnet dot ibm dot com> <5412C3F0 dot 9000703 at redhat dot com> <20140912130051 dot GA4871 at adacore dot com> <5412F714 dot 3040500 at redhat dot com> <20140912135012 dot GC4871 at adacore dot com> <54130176 dot 1070208 at gmail dot com> <541310E1 dot 5000806 at redhat dot com> <20140912171051 dot GF4871 at adacore dot com>
On 09/12/2014 06:10 PM, Joel Brobecker wrote:
>>> I'm writing a test that converts all gdb_run_cmd -> gdb_expect
>>> cases to avoid this from spreading further.
>>
>> Patch pasted below.
>
> Thanks Pedro. I started reviewing it, and then switch to scanner-mode
> half way through. It looks great!
Thanks Joel. Now pushed.
>> In a2-run.exp I converted one vxworks path, but left the others
>> in place... I'm tempted to nuke most of that vxworks stuff
>> out of the testsuite. Does anyone still care about it?
>
> I suspect no one does. I even suspect that no one even cares
> about whatever old version of vxworks is supported by GDB.
> IIRC, that code pre-dates my involvement in the GDB project,
> which started around 2001.
Oh, I notice that the vxworks support the testsuite is caring
about must be for a "target vxworks_or_something", not
"target remote", because we have in
gdb/testsuite/gdb.base/default.exp:
} elseif [istarget "*-*-vxworks*"] then {
gdb_test "set args" ".*" ""
gdb_test "r" "Starting program: .*
You must specify a function name to run, and arguments if any"\
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"run \"r\" abbreviation"
gdb_test "set args main" ".*" ""
And indeed, that target has been removed 10 years ago already ...
commit e84ecc995d6a5e4e9114d3cea61717b8a573afb6
Author: Andrew Cagney <cagney@redhat.com>
AuthorDate: Sat Nov 13 23:10:02 2004 +0000
2004-11-13 Andrew Cagney <cagney@gnu.org>
* configure.tgt: Delete i[34567]86-*-vxworks*, m68*-netx-*,
m68*-*-vxworks*, mips*-*-vxworks*, powerpc-*-vxworks*, and
sparc-*-vxworks*.
* NEWS: Mention that vxworks was deleted.
Which had:
-static void
-vx_create_inferior (char *exec_file, char *args, char **env, int from_tty)
-{
- enum clnt_stat status;
- arg_array passArgs;
- TASK_START taskStart;
-
- memset ((char *) &passArgs, '\0', sizeof (passArgs));
- memset ((char *) &taskStart, '\0', sizeof (taskStart));
-
- /* parse arguments, put them in passArgs */
-
- parse_args (args, &passArgs);
-
- if (passArgs.arg_array_len == 0)
- error ("You must specify a function name to run, and arguments if any");
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
So I'm going to delete all that cruft.
OOC, how does one debug Ravenscar then? Does that sit on top of
target remote ?
Thanks,
Pedro Alves