This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Cc: dblaikie at gmail dot com, ccoutant at google dot com
- Date: Fri, 12 Sep 2014 16:29:11 -0700
- Subject: [PATCH] Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
- Authentication-results: sourceware.org; auth=none
Hi.
Way back when, I made DW_FORM_GNU_addr_index in Fission skeleton CUs
an error. There's no need for this restriction, so this patch removes it.
David, is this something you'd like to see in 7.8.1?
It's safe enough for me to add it there.
2014-09-12 Doug Evans <dje@google.com>
* dwarf2read.c (read_attribute_value): Allow DW_FORM_GNU_addr_index
in Fission skeleton CUs.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index be32309..430a945 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -16077,14 +16077,6 @@ read_attribute_value (const struct die_reader_specs *reader,
info_ptr = read_attribute_value (reader, attr, form, info_ptr);
break;
case DW_FORM_GNU_addr_index:
- if (reader->dwo_file == NULL)
- {
- /* For now flag a hard error.
- Later we can turn this into a complaint. */
- error (_("Dwarf Error: %s found in non-DWO CU [in module %s]"),
- dwarf_form_name (form),
- bfd_get_filename (abfd));
- }
DW_ADDR (attr) = read_addr_index_from_leb128 (cu, info_ptr, &bytes_read);
info_ptr += bytes_read;
break;