This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Change form of prompt argument to with_gdb_prompt.
- From: Doug Evans <xdje42 at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 13 Sep 2014 15:54:53 -0700
- Subject: Re: [PATCH] Change form of prompt argument to with_gdb_prompt.
- Authentication-results: sourceware.org; auth=none
- References: <m3a96ctvbf dot fsf at sspiff dot org>
Doug Evans <email@example.com> writes:
> I had occasion to use with_gdb_prompt in a test for the patch for PR 17314
> and was passing the plain text prompt as the value, "(top-gdb)",
> instead of a regexp, "\(top-gdb\)" (expressed as "\\(top-gdb\\)" in TCL).
> I then discovered that in order to restore the prompt gdb passes the
> original value of $gdb_prompt to "set prompt", which works because
> "set prompt \(gdb\) " is equivalent to "set prompt (gdb) ".
> Perhaps I'm being overly cautious but this feels a bit subtle,
> but at any rate as an API choice I'd much rather pass the plain text
> form to with_gdb_prompt. The comments added to with_gdb_prompt feel
> a bit wordy ... excessive FAOD?
> I also discovered that the initial value of gdb_prompt is set in
> two places to two different values.
> At the global level gdb.exp sets it to "\[(\]gdb\[)\]"
> and default_gdb_init sets it to "\\(gdb\\)".
> The former form is undesirable as an argument to "set prompt",
> but it's not clear to me that just deleting this code won't break
> anything. Thus I just changed the value to be consistent and added
> a comment.
> 2014-09-06 Doug Evans <firstname.lastname@example.org>
> * lib/gdb.exp (gdb_prompt): Add comment and change initial value to
> be consistent with what default_gdb_init uses.
> (with_gdb_prompt): Change form of PROMPT argument from a regexp to
> the plain text of the prompt. Add some logging printfs.
> * gdb.perf/disassemble.exp: Update call to with_gdb_prompt.