This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Check function is GC'ed
- From: Yao Qi <yao at codesourcery dot com>
- To: Doug Evans <dje at google dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 19 Sep 2014 17:04:18 +0800
- Subject: Re: [PATCH 1/3] Check function is GC'ed
- Authentication-results: sourceware.org; auth=none
- References: <53D8A264 dot 1050103 at codesourcery dot com> <1408609338-17561-1-git-send-email-yao at codesourcery dot com> <21495 dot 32892 dot 341399 dot 802579 at ruffy2 dot mtv dot corp dot google dot com> <87sikggadr dot fsf at codesourcery dot com> <21527 dot 13753 dot 980949 dot 662368 at ruffy2 dot mtv dot corp dot google dot com> <87ioko1ec0 dot fsf at codesourcery dot com> <21531 dot 2907 dot 799313 dot 742622 at ruffy2 dot mtv dot corp dot google dot com>
Doug Evans <dje@google.com> writes:
> > gdb:
> >
> > 2014-09-16 Yao Qi <yao@codesourcery.com>
> >
> > * dwarf2read.c (dwarf_decode_lines): Update declaration.
> > (handle_DW_AT_stmt_list): Add argument 'lowpc'. Update
> > comments. Callers update.
> > (dwarf_decode_lines): Likewise.
> > (dwarf_decode_lines_1): Add argument 'lowpc'. Update
> > comments. Skip the line table if 'lowpc' is greater than
> > 'address'. Don't check
> > dwarf2_per_objfile->has_section_at_zero.
> >
> > gdb/testsuite:
> >
> > 2014-09-16 Yao Qi <yao@codesourcery.com>
> >
> > * gdb.base/break-on-linker-gcd-function.exp: Move test into new
> > proc set_breakpoint_on_gcd_function. Invoke
> > set_breakpoint_on_gcd_function. Restart GDB with --readnow and
> > invoke set_breakpoint_on_gcd_function again.
>
> LGTM.
Thanks for the review. Patch is pushed in.
--
Yao (éå)