This is the mail archive of the
mailing list for the GDB project.
automated testing comment [Re: time to workaround libc/13097 in fsf gdb?]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Doug Evans <xdje42 at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 23 Sep 2014 12:58:55 +0200
- Subject: automated testing comment [Re: time to workaround libc/13097 in fsf gdb?]
- Authentication-results: sourceware.org; auth=none
- References: <5411CFAE dot 7040805 at redhat dot com> <20140912115452 dot GA5626 at host2 dot jankratochvil dot net> <5412E3AC dot 80203 at redhat dot com> <20140912123320 dot GA8704 at host2 dot jankratochvil dot net> <5412EB1F dot 40309 at redhat dot com> <20140917201049 dot GA22880 at host2 dot jankratochvil dot net> <541C3FCF dot 4000400 at redhat dot com> <541C409E dot 6010408 at redhat dot com> <20140920213033 dot GA6255 at host2 dot jankratochvil dot net> <541F2311 dot 1040404 at redhat dot com>
On Sun, 21 Sep 2014 21:12:17 +0200, Pedro Alves wrote:
> On 09/20/2014 10:30 PM, Jan Kratochvil wrote:
> > But for example kernel-2.6.32-220.el6.x86_64 is "prelinked", see below.
> Ah, didn't know that. That's the sort of thing we should have in
> comments in the code, or at least in the commit log.
That apparently would not work, comment is added only after the problem is
It would be found by automated testing upon submitting patch for reviews, such
as I have seen done through Jenkins connected to Gerrit.
At least assuming the same "prelinked vDSO" (which is definitely not done by
the prelink program) issue also happens on some non-Fedora/non-RHEL OSes
(as Fedora/RHEL OSes have patched glibc where the vDSO is not listed in the
link map at all and so the patch being discussed is not needed there).
And sure deploying automated testing with the current GDB testsuite as is
would not work now automatically as the testsuite has fuzzy results. Although
at least running new testcases (from the patch under review) would work which
would be sufficient in this case (but not in other cases - regression cases).