This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes
- From: Gary Benson <gbenson at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 26 Sep 2014 09:23:52 +0100
- Subject: Re: [PATCH] Remove support for "rtld_" prefix on solib-svr4 probes
- Authentication-results: sourceware.org; auth=none
- References: <1411581801-19126-1-git-send-email-sergiodj at redhat dot com> <5423F08B dot 1040409 at redhat dot com> <87bnq3h1gf dot fsf_-_ at redhat dot com> <54248579 dot 8030606 at redhat dot com> <87r3yzfl86 dot fsf at redhat dot com> <54248CD1 dot 8000801 at redhat dot com> <87eguzfju7 dot fsf at redhat dot com> <54249203 dot 3030607 at redhat dot com> <87vbobe3yu dot fsf at redhat dot com>
Sergio Durigan Junior wrote:
> On Thursday, September 25 2014, Pedro Alves wrote:
> > The real point was that the user building GDB may have no control
> > over the system bits of the distro it is building GDB for (in this
> > case glibc's loader), just like when building for a proprietary
> > OS, even though GNU/Linux distros are based (mostly) on free
> > sources.
> Yeah, that is a fair point, and it is very valid when we talk about
> things that might make GDB break badly when removed. But in this
> case, we are talking about a very specific Fedora/RHEL thing, which
> is itself intended to improve something (i.e., GDB will still work
> without it on old Fedora/RHEL systems), so I think most of the
> concerns don't apply here.
The code is dead, but only recently so. It's still warm :)
Removing the prefixed-probes code would reintroduce this:
My preference is to leave the prefixes in, at least for now; you don't
know what people are using out there. The comment lists affected OS
versions so future reviewers will be able to decide how relevant it
I don't think we need to bother with prefix support in the testsuite,
but we should probably switch to a probe that GDB is using like Pedro
mentioned earlier. "reloc_complete" would be good.