Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups

[Simon Marchi <simon dot marchi at ericsson dot com>]

On 2014-06-04 02:09 PM, Tom Tromey wrote:
> Pedro> Sure, but that's not the point.  The point is that frontend might
> Pedro> not be _parsing_ the number _at all_, but just presenting it as a
> Pedro> string to the user as is (*).
> 
> It's unfortunate that we can even be in this situation.
> 
> I don't object to using octal.  I was unaware of the precedent.
> 
> However now it seems that it would be an improvement to document that
> the exit code is emitted in octal.
> 
> Tom

I am cleaning up the branches of my git repo and realized that this patch fell
between the cracks.

Since it was OKed a long time ago by Pedro [1] in pretty much the same form as
this one, I will push it as follows tomorrow if nobody objects. The only change:
As Tom suggested, I added a mention in the doc that the field is formatted in octal.

[1] https://sourceware.org/ml/gdb-patches/2013-06/msg00768.html


>From ab77bca570bfe59bef85b8de4874459a7d70ec83 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 29 Sep 2014 17:33:09 -0400
Subject: [PATCH] Exit code of exited inferiors in -list-thread-groups

Don't reset the exit code at inferior exit and print it in
-list-thread-groups.

gdb/ChangeLog:

	* NEWS: Announce new exit-code field in -list-thread-groups
	output.
	* inferior.c (exit_inferior_1): Don't clear exit code.
	(inferior_appeared): Clear exit code.
	* mi/mi-main.c (print_one_inferior): Add printing of the exit
	code.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-exit-code.exp: New file.
	* gdb.mi/mi-exit-code.c: New file.

gdb/doc/ChangeLog:

	* gdb.texinfo (Miscellaneous gdb/mi Commands): Document new
	exit-code field in -list-thread-groups output.
---
 gdb/NEWS            | 5 +++++
 gdb/doc/gdb.texinfo | 5 +++++
 gdb/inferior.c      | 4 ++--
 gdb/mi/mi-main.c    | 3 +++
 4 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 11326f1..50a7e95 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -40,6 +40,11 @@ queue-signal signal-name-or-number
   even in non-stop mode.  The "auto" mode has been removed, and "off"
   is now the default mode.

+* MI changes
+
+  ** The -list-thread-groups command outputs an exit-code firld for
+     inferiors that have exited.
+
 *** Changes in GDB 7.8

 * New command line options
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 026706a..d9a24a2 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -31152,6 +31152,11 @@ valid type.
 The target-specific process identifier.  This field is only present
 for thread groups of type @samp{process} and only if the process exists.

+@item exit-code
+The exit code of this thread group when it last exited, formatted in octal.
+This field is only present for thread groups of type @samp{process} and
+only if the process is not running.
+
 @item num_children
 The number of children this thread group has.  This field may be
 absent for an available thread group.
diff --git a/gdb/inferior.c b/gdb/inferior.c
index 23da0c7..66401ab 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -275,8 +275,6 @@ exit_inferior_1 (struct inferior *inftoex, int silent)
       inf->vfork_child = NULL;
     }

-  inf->has_exit_code = 0;
-  inf->exit_code = 0;
   inf->pending_detach = 0;
 }

@@ -322,6 +320,8 @@ void
 inferior_appeared (struct inferior *inf, int pid)
 {
   inf->pid = pid;
+  inf->has_exit_code = 0;
+  inf->exit_code = 0;

   observer_notify_inferior_appeared (inf);
 }
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 59717ca..4d35ff0 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -658,6 +658,9 @@ print_one_inferior (struct inferior *inferior, void *xdata)

       ui_out_field_fmt (uiout, "id", "i%d", inferior->num);
       ui_out_field_string (uiout, "type", "process");
+      if (inferior->has_exit_code)
+	ui_out_field_string (uiout, "exit-code",
+			     int_string (inferior->exit_code, 8, 0, 0, 1));
       if (inferior->pid != 0)
 	ui_out_field_int (uiout, "pid", inferior->pid);

-- 
2.1.0