This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/9] Put single-step breakpoints on the bp_location chain


On 09/28/2014 01:32 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> @@ -15496,22 +15466,9 @@ single_step_breakpoints_inserted (void)
>>  void
>>  remove_single_step_breakpoints (void)
>>  {
>> -  gdb_assert (single_step_breakpoints[0] != NULL);
>> +  gdb_assert (single_step_breakpoints != NULL);
>>  
>> -  /* See insert_single_step_breakpoint for more about this deprecated
>> -     call.  */
>> -  deprecated_remove_raw_breakpoint (single_step_gdbarch[0],
>> -				    single_step_breakpoints[0]);
>> -  single_step_gdbarch[0] = NULL;
>> -  single_step_breakpoints[0] = NULL;
>> -
>> -  if (single_step_breakpoints[1] != NULL)
>> -    {
>> -      deprecated_remove_raw_breakpoint (single_step_gdbarch[1],
>> -					single_step_breakpoints[1]);
>> -      single_step_gdbarch[1] = NULL;
>> -      single_step_breakpoints[1] = NULL;
>> -    }
>> +  delete_breakpoint (single_step_breakpoints);
> 
> We need to set single_step_breakpoints back to NULL.  This causes many
> fails for arm-linux-gnueabi target, as I tested.

Thanks Yao.

I'll try to figure out why I didn't see that in my testing...

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]