This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/3] Clean up server-kill.exp
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: <palves at redhat dot com>
- Date: Wed, 8 Oct 2014 14:27:57 +0800
- Subject: [PATCH 1/3] Clean up server-kill.exp
- Authentication-results: sourceware.org; auth=none
- References: <543404EF dot 4010306 at redhat dot com> <1412749679-27076-1-git-send-email-yao at codesourcery dot com>
This patch is to remove some lines which looks unnecessary. These
lines were added when server-kill.exp was added. In the version 1,
https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test
calls runto_main and delete breakpoint on main,
+if ![runto_main] {
+ return -1
+}
+
+# Otherwise the breakpoint at 'main' would not cause insert breakpoints during
+# first step.
+delete_breakpoints
However, in the version 2
https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main
is removed but delete_breakpoints is still there. AFAICS, the line of
delete_breakpoints can be removed too.
gdb/testsuite:
2014-10-08 Yao Qi <yao@codesourcery.com>
* gdb.server/server-kill.exp: Remove "delete_breakpoints".
---
gdb/testsuite/gdb.server/server-kill.exp | 4 ----
1 file changed, 4 deletions(-)
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 5d31103..b23c2b5 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -33,10 +33,6 @@ gdb_test "disconnect" ".*"
gdbserver_run ""
-# Otherwise the breakpoint at 'main' would not cause insert
-# breakpoints during first step.
-delete_breakpoints
-
set server_pid [exp_pid -i [board_info target fileid]]
remote_exec target "kill -9 $server_pid"
--
1.9.3