This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Remove spurious exceptions.h inclusions
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 09 Oct 2014 12:43:33 +0100
- Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions
- Authentication-results: sourceware.org; auth=none
- References: <1409586154-16196-1-git-send-email-gbenson at redhat dot com> <1409586154-16196-2-git-send-email-gbenson at redhat dot com> <CADPb22RcwUGPEwGGc7hG=4R0KvRV9axKDbQ6Nu1PHys5Nk=t8A at mail dot gmail dot com> <CADPb22QC=J=tpyMo_y3mMi22eQh5ub2E6LjGVDrrEOCTXgVPBw at mail dot gmail dot com> <CADPb22Q040fXbTS1tAkojuJE6g=mNm+B_=U7Q0dvSV2i8PLZHA at mail dot gmail dot com> <20141009094319 dot GA6910 at blade dot nx>
On 10/09/2014 10:43 AM, Gary Benson wrote:
> Doug Evans wrote:
>> Can you also update the Include files section of the coding standards?
>> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>>
>> This section needs to list exceptions.h and others that .c and .h
>> files are no longer supposed to directly include.
>
> I have updated it. Rather than adding a long list of headers that
> will undoubtedly rot I have specified that files should not include
> stuff included by whichever of defs.h, server.h, common-defs.h is
> relevant. The wording is not ideal but it's the best I could come
> up with.
Thanks Gary. I've extended it a bit to mention the ".c file must include
its header" rule, which I think ends up clarifying it too.
Thanks,
Pedro Alves