This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Oct 2014 18:38:13 +0200
- Subject: Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.
- Authentication-results: sourceware.org; auth=none
- References: <1411724905-31234-1-git-send-email-jose dot marchesi at oracle dot com> <1411724905-31234-4-git-send-email-jose dot marchesi at oracle dot com> <87mw9g4s8q dot fsf at redhat dot com>
Hi Sergio.
> This patch adds the above-mentioned commands to the generic probe abstraction
> implemented in probe.[ch]. The effects associated to enabling or disabling a
> probe depend on the type of probe being handled, and is triggered by invoking
> two back-end hooks in `probe_ops'.
>
> In case some particular probe type does not support the notion of enabling
> and/or disabling, the corresponding fields on `probe_ops' can be initialized
> to NULL. This is the case of SystemTap probes.
Thanks for the patch, Jose. Comments below, as usual.
I agree/comply with all these comments :)