This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: gdbserver crash on win XP during watchpoint removal
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 15 Oct 2014 07:35:01 -0700
- Subject: Re: RFC: gdbserver crash on win XP during watchpoint removal
- Authentication-results: sourceware.org; auth=none
- References: <20141014184647 dot GB8879 at adacore dot com> <543D782F dot 10506 at redhat dot com> <20141014213727 dot GA25846 at adacore dot com> <543DC1FF dot 8030109 at redhat dot com>
> > It looks like just removing the statement that sets dr_control_mirror
> > from the thread's DR7 is sufficient to allow hardware watchpoints
> > to work again.
>
> Yes, that sounds good enough for 7.8.1. This is OK.
Thanks, Pedro. I created PR server/17487 for this, and pushed
the patch on gdb-7.8-branch using that PR.
> > I admit I could have spent a little more time trying to understand
> > the bigger picture, but I'm a bit under time pressure, so I'm hoping
> > this is enough. Otherwise, I'll look at a better fix.
>
> Hmm, I've wanted to do this for a while. So... Below's is what I
> think is the better fix.
Thanks! I tested your patch on x86-windows using AdaCore's testsuite,
and it also fixes the problem, with no regression. Do you want to push
it? I left the PR open pending your patch going in...
--
Joel