This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't check target_info exists noargs in commands.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 Oct 2014 18:26:14 +0100
- Subject: Re: [PATCH] Don't check target_info exists noargs in commands.exp
- Authentication-results: sourceware.org; auth=none
- References: <1413167285-14378-1-git-send-email-yao at codesourcery dot com> <543E7F2F dot 5040404 at redhat dot com> <87bnpcmva3 dot fsf at codesourcery dot com>
On 10/16/2014 06:35 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> Makes sense to me. Though it looks to me like to be
>> thorough we should remove all the "set args ..." lines too, like:
>>
>>> gdb_test_no_output "set args 5" "set args in progvar_simple_while_test"
>> ^^^^^^^^^^
>>> if { ![runto factorial] } then { gdb_suppress_tests }
>>> # Don't depend upon argument passing, since most simulators don't
>>
>> and several more as visible in the patch.
>
> Right, the updated patch below removes "set args" line too.
>
Looks good.
Thanks,
Pedro Alves