This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] ARM: arm_breakpoint should be little endian form in case for arm BE8
- From: Yao Qi <yao at codesourcery dot com>
- To: Victor Kamensky <victor dot kamensky at linaro dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 21 Oct 2014 16:09:59 +0800
- Subject: Re: [PATCH 3/5] ARM: arm_breakpoint should be little endian form in case for arm BE8
- Authentication-results: sourceware.org; auth=none
- References: <1413853021-4393-1-git-send-email-victor dot kamensky at linaro dot org> <1413853021-4393-4-git-send-email-victor dot kamensky at linaro dot org>
Victor Kamensky <victor.kamensky@linaro.org> writes:
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 2aef5dc..c32fb3f 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
> 2014-10-13 Victor Kamensky <victor.kamensky@linaro.org>
>
> + * arm-tdep.c: (extract_arm_insn): use dbarch_byte_order_for_code
> + to read arm instruction.
The file and function name in the changelog entry is wrong. The
description of each entry is a sentence, so the first letter should be
capitalized.
* arm-linux-tdep.c (arm_linux_init_abi): Use
gdbarch_byte_order_for_code to read arm instruction.
Otherwise, it looks good to me.
--
Yao (éå)