This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Python API: Add gdb.is_in_prologue and gdb.is_in_epilogue.
- From: Pedro Alves <palves at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>, gdb-patches at sourceware dot org
- Date: Wed, 22 Oct 2014 22:59:23 +0100
- Subject: Re: [PATCH] Python API: Add gdb.is_in_prologue and gdb.is_in_epilogue.
- Authentication-results: sourceware.org; auth=none
- References: <1413986485-4673-1-git-send-email-martin dot galvan at tallertechnologies dot com> <544822D6 dot 8020606 at redhat dot com>
On 10/22/2014 10:34 PM, Pedro Alves wrote:
>> +# Get the current frame object.
>> > +gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \
>> > + "Get the current frame object." 0
> Lowercase, and no "." please. Here and throughout. Usual style is to
> drop the "the"s to be more concise:
>
> gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \
^^^^^^^^
> "get current frame object" 0
^^^^^^^
BTW, I happened to read this back, and noticed: "current" and "selected"
have distinct meanings in the frame machinery. Best not mix them up:
gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \
"get selected frame object" 0
Thanks,
Pedro Alves