This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] ARM: stricter __stack_chk_guard check during prologue
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 24 Oct 2014 16:25:04 +0800
- Subject: Re: [RFA] ARM: stricter __stack_chk_guard check during prologue
- Authentication-results: sourceware.org; auth=none
- References: <20141022142231 dot GF4786 at adacore dot com> <87y4s7h553 dot fsf at codesourcery dot com> <20141023153947 dot GA11707 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> writes:
Joel,
I run regression tests on arm-linux-gnueabi with your patch. There are
some fails on armv4t arm and thumb mode. It is an existing bug
introduced by my patch :( and your patch just exposed it. I'll fix it separately.
> /* If name of symbol doesn't start with '__stack_chk_guard', this
> instruction sequence is not for stack protector. If symbol is
> removed, we conservatively think this sequence is for stack protector. */
We need to update the comment to sync with the code below.
> - if (stack_chk_guard.minsym
> - && strncmp (MSYMBOL_LINKAGE_NAME (stack_chk_guard.minsym),
> + if (stack_chk_guard.minsym == NULL
> + || strncmp (MSYMBOL_LINKAGE_NAME (stack_chk_guard.minsym),
> "__stack_chk_guard",
> strlen ("__stack_chk_guard")) != 0)
Otherwise, it looks good to me.
--
Yao (éå)