This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] tui: Fix newterm call for older ncurses
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 4 Nov 2014 14:17:10 -0500
- Subject: Re: [PATCH] tui: Fix newterm call for older ncurses
- Authentication-results: sourceware.org; auth=none
- References: <1415107885-18095-1-git-send-email-simon dot marchi at ericsson dot com> <5459241C dot 4000202 at redhat dot com>
On 2014-11-04 02:08 PM, Pedro Alves wrote:
> On 11/04/2014 01:31 PM, Simon Marchi wrote:
>> Older versions of ncurses' newterm can't take NULL for their ofp and ifp
>> parameters. Newer versions can, and they fall back on stdout/stdin if
>> that is the case.
>>
>> This patch explicitely passes stdout/stdin to the call to newterm to
>
> "explicitly"
>
>> avoid segfaulting with older ncurses.
>>
>> Reference: https://sourceware.org/ml/gdb-patches/2014-11/msg00055.html
>>
>
> OK.
>
>> gdb/Changelog:
>>
>> 2014-11-04 Simon Marchi <simon.marchi@ericsson.com>
>>
>> * tui/tui.c (tui_enable): Pass pass stdout and stdin to newterm.
>
> Double "pass".
>
> Thanks,
> Pedro Alves
Pushed with the fixes to the commit message and ChangeLog, thanks.