RE: [PATCH 02/12] btrace: add format argument to supports_btrace

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Wednesday, November 5, 2014 9:45 PM


> > Moved declarations in btrace-common.h around to break a cyclic
> dependency
> > with gdbserver/server.h.
> 
> This should no longer be necessary since
> 462f517e5020a464e84d2b8535b1b68d39329dc2.

Good.  It indeed is no longer necessary.


> > +/* Target specific branch trace information.  */
> > +struct btrace_target_info;
> > +
> > +/* Enumeration of btrace read types.  */
> > +
> > +enum btrace_read_type
> > +{
> > +  /* Send all available trace.  */
> > +  BTRACE_READ_ALL,
> > +
> > +  /* Send all available trace, if it changed.  */
> > +  BTRACE_READ_NEW,
> > +
> > +  /* Send the trace since the last request.  This will fail if the trace
> > +     buffer overflowed.  */
> > +  BTRACE_READ_DELTA
> > +};
> 
> What does "Send" mean here?

It means as much as "read".  It determines what trace you'll get
when reading btrace.

I realize it's the producer's view; it should rather be the consumer's
view.  Do you want me to change it in a separate patch?

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052