This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 02/12] btrace: add format argument to supports_btrace
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 14 Nov 2014 13:47:37 +0000
- Subject: RE: [PATCH 02/12] btrace: add format argument to supports_btrace
- Authentication-results: sourceware.org; auth=none
- References: <1405346196-1804-1-git-send-email-markus dot t dot metzger at intel dot com> <1405346196-1804-3-git-send-email-markus dot t dot metzger at intel dot com> <545A8C5B dot 3040504 at redhat dot com> <A78C989F6D9628469189715575E55B231E673C5C at IRSMSX104 dot ger dot corp dot intel dot com> <5466056E dot 5060202 at redhat dot com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Friday, November 14, 2014 2:37 PM
> >>> +enum btrace_read_type
> >>> +{
> >>> + /* Send all available trace. */
> >>> + BTRACE_READ_ALL,
> >>> +
> >>> + /* Send all available trace, if it changed. */
> >>> + BTRACE_READ_NEW,
> >>> +
> >>> + /* Send the trace since the last request. This will fail if the trace
> >>> + buffer overflowed. */
> >>> + BTRACE_READ_DELTA
> >>> +};
> >>
> >> What does "Send" mean here?
> >
> > It means as much as "read". It determines what trace you'll get
> > when reading btrace.
> > I realize it's the producer's view; it should rather be the consumer's
> > view.
>
> Ah, yeah.
>
> > Do you want me to change it in a separate patch?
>
> Hmm, I'm confused -- why a separate patch instead of simply
> adjusting this one?
Because this chunk will go away. As you pointed out, moving
declarations around is no longer necessary and this change is unrelated.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052