This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 02/12] btrace: add format argument to supports_btrace
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 14 Nov 2014 13:50:28 +0000
- Subject: Re: [PATCH 02/12] btrace: add format argument to supports_btrace
- Authentication-results: sourceware.org; auth=none
- References: <1405346196-1804-1-git-send-email-markus dot t dot metzger at intel dot com> <1405346196-1804-3-git-send-email-markus dot t dot metzger at intel dot com> <545A8C5B dot 3040504 at redhat dot com> <A78C989F6D9628469189715575E55B231E673C5C at IRSMSX104 dot ger dot corp dot intel dot com> <5466056E dot 5060202 at redhat dot com> <A78C989F6D9628469189715575E55B231E673D7D at IRSMSX104 dot ger dot corp dot intel dot com>
On 11/14/2014 01:47 PM, Metzger, Markus T wrote:
>> owner@sourceware.org] On Behalf Of Pedro Alves
>>> Do you want me to change it in a separate patch?
>>
>> Hmm, I'm confused -- why a separate patch instead of simply
>> adjusting this one?
>
> Because this chunk will go away. As you pointed out, moving
> declarations around is no longer necessary and this change is unrelated.
D'oh!
If you want to push a fix for that as a separate patch, it's
preapproved.
Thanks,
Pedro Alves