This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
- From: Doug Evans <xdje42 at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: "Maciej W. Rozycki" <macro at codesourcery dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, Rich Fuhler <rich at mips dot com>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Sun, 16 Nov 2014 11:48:41 -0800
- Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1204202134510 dot 19835 at tp dot orcam dot me dot uk> <20120611182043 dot GA7597 at adacore dot com> <alpine dot DEB dot 1 dot 10 dot 1409292313170 dot 4971 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1410060021570 dot 19130 at tp dot orcam dot me dot uk> <20141116110934 dot GH5774 at adacore dot com> <CAP9bCMSKvBGREy_nXKRbA9E=7QsK1o-roENVms4yVWY4jJ4-8A at mail dot gmail dot com>
Doug Evans <xdje42@gmail.com> writes:
> On Sun, Nov 16, 2014 at 3:09 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>>> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
>>> ===================================================================
>>> ---
>>> gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
>>> 2014-10-02 07:56:23.000000000 +0100
>>> +++
>>> gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
>>> 2014-10-02 07:58:10.978958268 +0100
>>> @@ -15,7 +15,8 @@
>>>
>>> .text
>>> .globl main
>>> -main: .byte 0
>>> +main:
>>> + .dc.l 0
>>
>> We've never used .dl.l before, and I don't know how widely available
>> it is (in fact, I couldn't find it in the GAS manual). How about using
>> .word or .4byte? It would also be consistent with what we've usually be
>> using. Would that work?
>
> Agreed.
Sorry for the followup, but FAOD, .4byte.
.word may be a different size on some platforms.