This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
- From: Doug Evans <xdje42 at gmail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, <gdb-patches at sourceware dot org>, Rich Fuhler <rich at mips dot com>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Sun, 16 Nov 2014 14:27:24 -0800
- Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1204202134510 dot 19835 at tp dot orcam dot me dot uk> <20120611182043 dot GA7597 at adacore dot com> <alpine dot DEB dot 1 dot 10 dot 1409292313170 dot 4971 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1410060021570 dot 19130 at tp dot orcam dot me dot uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> Joel,
>
> Here's the second change, to cover issues triggered by the MIPS ISA bit
> handling change, usually in tests that make artificial DWARF-2 records.
>
> [...]
> 2014-10-06 Maciej W. Rozycki <macro@codesourcery.com>
>
> gdb/testsuite/
> * gdb.cp/expand-psymtabs-cxx.exp: Accept any address of
> `method(long)', not just 0x0.
> * gdb.cp/nsalias.exp: Align code labels to 4.
> * gdb.dwarf2/dw2-canonicalize-type.S (main): Expand to 4-bytes.
> * gdb.dwarf2/dw2-empty-pc-range.S (main): Likewise.
> * gdb.dwarf2/pr11465.S (_ZN1N1cE): Likewise.
> * gdb.dwarf2/dw2-case-insensitive.c (START_INSNS): New macro.
> (cu_text_start, FUNC_lang_start): Use `START_INSNS'.
> * gdb.dwarf2/dw2-stack-boundary.exp: Accept noise in complaints.
> [...]
> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
> ===================================================================
> --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c 2014-10-02 07:56:23.000000000 +0100
> +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c 2014-10-02 07:58:10.978958268 +0100
> @@ -15,13 +15,22 @@
> You should have received a copy of the GNU General Public License
> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>
> +/* Target-specific way of forcing an instruction label. */
> +#ifdef __mips__
> +#define START_INSNS asm (".insn");
> +#else
> +#define START_INSNS
> +#endif
> +
> /* Use DW_LANG_Fortran90 for case insensitive DWARF. */
> asm (".globl cu_text_start");
> asm ("cu_text_start:");
> +START_INSNS
>
> asm (".globl FUNC_lang_start");
> asm (".p2align 4");
> asm ("FUNC_lang_start:");
> +START_INSNS
>
> void
> FUNC_lang (void)
Hi.
Just a note to say this will probably not work with clang,
but this test is already clang unfriendly.
We can leave fixing that for another day.
I have no other comments on the part of the patch set,
so ok by me (with the .4byte change).
[Still working on part 1.]