This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/7] Include wchar.h and wctype.h unconditionally
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 21 Nov 2014 21:22:17 +0800
- Subject: Re: [PATCH 6/7] Include wchar.h and wctype.h unconditionally
- Authentication-results: sourceware.org; auth=none
- References: <1416057612-16155-1-git-send-email-yao at codesourcery dot com> <1416057612-16155-7-git-send-email-yao at codesourcery dot com> <546F34BA dot 20809 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> It's hard to reason about all the modes supported here, but
> I think this is OK. Seems like the comment above about wchar_t
> support should be updated though.
>
At the beginning, I tried to change more than what I did in this patch,
but I got myself in trouble in these different modes, which I don't
fully understand. I'll revisit it once my gnulib patches queue is empty.
> (I wonder whether if we pulled in the gnulib btowc module, we could
> get rid of at least some of this fallback stuff. We're already
> pulling in mbrtowc...)
Agreed, that is one thing we could do.
--
Yao (éå)