This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't enable gdbtk in testsuite
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 04 Dec 2014 17:06:57 +0000
- Subject: Re: [PATCH] Don't enable gdbtk in testsuite
- Authentication-results: sourceware.org; auth=none
- References: <1416903049-30419-1-git-send-email-yao at codesourcery dot com>
On 11/25/2014 08:10 AM, Yao Qi wrote:
> When I skim configure.ac and Makefile.in in gdb/testsuite, I happen to
> see that directory gdb.gdbtk is added to subdirs, however it doesn't
> exist. gdb/testsuite/gdb.gdbtk was removed by the patch below,
>
> [rfa] git repo fixup: delete gdb/testsuite/gdb.gdbtk
> http://thread.gmane.org/gmane.comp.gdb.patches/61489
That patch removed it from the git repo, mirroring how CVS modules
worked. In CVS, if you checkout the "gdb" module, you don't get
the gdbtk dirs, but if you checkout the insight module instead, you
get everything gdb, plus the insight bits: src/gdb/gdbtk subdir,
src/gdb/testsuite/gdb.gdbtk/, and maybe other bits.
So removing the testsuite support for gdbtk doesn't seem like
the right thing to do. Particularly since we still have the
gdbtk bits in gdb/configure.ac. IOW, I don't see how
src/gdb/testsuite/gdb.gdbtk/ not being around is different
from src/gdb/gdbtk/ not being around. We should either keep
all support for gdbtk, or remove all of it.
Thanks,
Pedro Alves