This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "mihail dot nistor at freescale dot com" <mihail dot nistor at freescale dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 13 Dec 2014 08:04:29 -0500
- Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file
- Authentication-results: sourceware.org; auth=none
- References: <1410954786-17690-1-git-send-email-mihail dot nistor at freescale dot com> <542459B9 dot 9090705 at redhat dot com> <23ca9e13576840e280392b69e5cc7de8 at BN1PR0301MB0628 dot namprd03 dot prod dot outlook dot com> <7dec43bc41e044fcbba3289ca7cb2697 at BN1PR0301MB0628 dot namprd03 dot prod dot outlook dot com> <542B0854 dot 6050804 at redhat dot com>
> gdb/ChangeLog:
> 2014-09-30 Keith Seitz <keiths@redhat.com>
> Mihail-Marian Nistor <mihail.nistor@freescale.com>
>
> PR gdb/17394
> * linespec.c (struct collect_minsyms): Add new member `symtab'.
> (add_minsym): Handle cases where info.symtab is non-NULL.
> (search_minsyms_for_name): Add new parameter `symtab'.
> Handle limiting searches to a specific symtab.
> (add_matching_symtabs_to_info): Search through minimal symbols
> for language_asm files for which no new symbols are found.
>
> gdb/testsuite/ChangeLog:
> 2014-09-30 Mihail-Marian Nistor <mihail.nistor@freescale.com>
>
> PR gdb/17394
> * gdb.linespec/break-asm-file.c: New file.
> * gdb.linespec/break-asm-file.exp: New file.
> * gdb.linespec/break-asm-file0.s: New file.
> * gdb.linespec/break-asm-file1.s: New file.
Overall, the patch looks good to me. Just a few trivial issues
hightlighted below, but the patch is otherwise approved.
> diff --git a/gdb/testsuite/gdb.linespec/break-asm-file.exp b/gdb/testsuite/gdb.linespec/break-asm-file.exp
> +
> +load_lib dwarf.exp
Trailing space here...
> diff --git a/gdb/testsuite/gdb.linespec/break-asm-file0.s b/gdb/testsuite/gdb.linespec/break-asm-file0.s
[...]
> @@ -0,0 +1,218 @@
> + .byte 1 /* DW_LNS_copy */
> +
> + .byte 0 /* DW_LNE_set_address */
This file has a few .byte's where the formatting is inconsistent with
the rest. Not critical, but would you mind fixing those?
> + .byte 1 /* DW_LNS_copy */
> +
Trailing spaces...
> diff --git a/gdb/testsuite/gdb.linespec/break-asm-file1.s b/gdb/testsuite/gdb.linespec/break-asm-file1.s
[...]
> + .byte 1 /* DW_LNS_copy */
> +
Trailing spaces again...
> + .byte 1 /* DW_LNS_copy */
> +
Ditto...
> + .4byte .Lend_func
> +
... and Ditto.
Thank you,
--
Joel