This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org, Kai Tietz <ktietz at redhat dot com>
- Date: Mon, 15 Dec 2014 13:14:49 -0500
- Subject: Re: [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command]
- Authentication-results: sourceware.org; auth=none
- References: <20141123192713 dot 32193 dot 57150 dot stgit at host1 dot jankratochvil dot net> <20141123192900 dot 32193 dot 65726 dot stgit at host1 dot jankratochvil dot net> <87r3w2vkhv dot fsf at codesourcery dot com> <20141214075258 dot GA26795 at host2 dot jankratochvil dot net> <87egs2vcfu dot fsf at codesourcery dot com> <20141214182341 dot GA2908 at host2 dot jankratochvil dot net> <87a92pvc0w dot fsf at codesourcery dot com> <20141215124358 dot GU5457 at adacore dot com> <20141215171225 dot GA19674 at host2 dot jankratochvil dot net>
> Does it mean that after upgrading gnulib we can drop the MS-Windows host
> routines (which need to be written yet) again?
Provided that the corresponding gnulib modules can in fact be
imported without problem, then my answer would be yes. As you
found out, it often does not work that way. So far, if you look
at your update, and yao's update not so long ago, it's 3 breakages
(I found 2, you found 1). gnulib provides a really nice abstraction
layer, but it does not always work the way we hoped!
> IMO a more clean solution would be s/gdb_select/select/g, drop
> gdb_select from mingw-hdep.c and import gnulib select instead which
> handles what gdb_select is there fore, hopefully more transparently.
> But I haven't tried any of that.
As Eli pointed out, it's not necessarily an easy change. I don't
see the relation between select and mkdtemp, but maybe I missed
something.
--
Joel