This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Thank you very much for your support. You will find enclosed a new patch. Thank you, Mihai -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com] Sent: Saturday, December 13, 2014 3:04 PM To: Keith Seitz Cc: Nistor Mihail-MNISTOR1; gdb-patches@sourceware.org Subject: Re: [PATCH v2] Bug 17394: we cannot put a break-point at a global function for ASM file > gdb/ChangeLog: > 2014-09-30 Keith Seitz <keiths@redhat.com> > Mihail-Marian Nistor <mihail.nistor@freescale.com> > > PR gdb/17394 > * linespec.c (struct collect_minsyms): Add new member `symtab'. > (add_minsym): Handle cases where info.symtab is non-NULL. > (search_minsyms_for_name): Add new parameter `symtab'. > Handle limiting searches to a specific symtab. > (add_matching_symtabs_to_info): Search through minimal symbols > for language_asm files for which no new symbols are found. > > gdb/testsuite/ChangeLog: > 2014-09-30 Mihail-Marian Nistor <mihail.nistor@freescale.com> > > PR gdb/17394 > * gdb.linespec/break-asm-file.c: New file. > * gdb.linespec/break-asm-file.exp: New file. > * gdb.linespec/break-asm-file0.s: New file. > * gdb.linespec/break-asm-file1.s: New file. Overall, the patch looks good to me. Just a few trivial issues hightlighted below, but the patch is otherwise approved. > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file.exp > b/gdb/testsuite/gdb.linespec/break-asm-file.exp > + > +load_lib dwarf.exp Trailing space here... > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file0.s > b/gdb/testsuite/gdb.linespec/break-asm-file0.s [...] > @@ -0,0 +1,218 @@ > + .byte 1 /* DW_LNS_copy */ > + > + .byte 0 /* DW_LNE_set_address */ This file has a few .byte's where the formatting is inconsistent with the rest. Not critical, but would you mind fixing those? > + .byte 1 /* DW_LNS_copy */ > + Trailing spaces... > diff --git a/gdb/testsuite/gdb.linespec/break-asm-file1.s > b/gdb/testsuite/gdb.linespec/break-asm-file1.s [...] > + .byte 1 /* DW_LNS_copy */ > + Trailing spaces again... > + .byte 1 /* DW_LNS_copy */ > + Ditto... > + .4byte .Lend_func > + ... and Ditto. Thank you, -- Joel
Attachment:
17394_v3.patch
Description: 17394_v3.patch
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |