This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, moxie, sim] Add mul.x and umul.x instruction support
- From: Doug Evans <xdje42 at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Anthony Green <green at moxielogic dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 24 Dec 2014 09:03:54 -0800
- Subject: Re: [PATCH, moxie, sim] Add mul.x and umul.x instruction support
- Authentication-results: sourceware.org; auth=none
- References: <87ioh1890s dot fsf at moxielogic dot com> <20141224134337 dot GR12884 at adacore dot com>
On Wed, Dec 24, 2014 at 5:43 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2014-12-24 Anthony Green <green@moxielogic.com>
>> [...]
> Can you add an empty line after the local variable declarations?
> This is part of GDB's Coding Standard...
>
> Also, you appear to have some code in between local variable
> declarations, which is not allowed (non C90, I think). Can you fix?
Maybe as a "baby step" towards a more modern gdb, can we relax these
for the sim tree?
Just a suggestion, I don't have a strong opinion, other than lamenting
the ways in which gdb is held back.
[I can't remember the last time we had this discussion for the sim tree.
If it was in the recent past, apologies. Let me know and I'll add
something to the wiki
to help prevent bringing this up again, at least in the near future.]