This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Thomas Preud'homme <thomas dot preudhomme at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 29 Dec 2014 16:09:24 +0400
- Subject: Re: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
- Authentication-results: sourceware.org; auth=none
- References: <000101d02201$e9b4b430$bd1e1c90$ at arm dot com> <20141228034726 dot GA2123 at adacore dot com> <000301d02350$313224b0$93966e10$ at arm dot com>
> > Also, I don't think the cast to (int) are necessary, are they?
>
> Sigh. Indeed, they aren't. My apologize. I remember adding them after
> seeing an error but I cannot reproduce it. So either I compiled with
> g++ (why would I?) or the error came from something else in the patch
> which I changed as well. Should I post a patch to fix this or can I
> commit it as obvious?
No worries at all - if you had seen the number of brainless changes
I've pushed (and I am not calling your change brainless ;-)), you
would feel sorry for me.
You can commit that change as obvious, no problem. But, in case we
haven't said it before, even obvious changes need to be posted here,
with ChangeLog and all.
Thank you,
--
Joel